feature(writer): add support for external decoded data sources #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
force-pushed
the
zerosnacks/trace-printer-revm-inspectors
branch
from
fae0f71
to
7984d56
Compare
|
Re-marking this as draft until print traces pass again Still, open for feedback |
|
Formatting has been fixed, Foundry tests are now passing: foundry-rs/foundry#8224 |
|
Can you add tests here too? Using |
Added, please note that it shows the application of patches, not necessarily the full decoding as implemented in Foundry |
mattsse
requested changes
Jun 27, 2024
DaniPopes
reviewed
Jun 27, 2024
DaniPopes
reviewed
Jun 27, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
mattsse
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14
nodes_mutfor mutability of nodes, required for populating added CallTrace fieldsdecoded.label,decoded.return_data,decoded.call_data, wrapped in theDecodedCallTracecontainer type.LogDatain aCallLogto accompany it with additional decoded data fields:decoded.name,decoded.params, wrapped in theDecodedCallLogcontainer type.decoded.contract_namehas not been added as a field as it is only used in Foundry's gas report, not in the current trace render.It is likely that some stylistic updates will be followed up relatively quickly
Related PR: foundry-rs/foundry#8224