Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync known revive issues with the latest resolc release 0.1.0-dev.5 #6

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

xermicus
Copy link
Member

No description provided.

Signed-off-by: xermicus <cyrill@parity.io>
@xermicus xermicus requested a review from athei October 30, 2024 11:04
@smiasojed
Copy link
Contributor

I think that we need to add info how to check the revive version which is being used with REMIX. It would be useful for bugs reporting. WDYT?

@xermicus
Copy link
Member Author

Yes that's a good idea. However would require another release I think.

@smiasojed
Copy link
Contributor

smiasojed commented Oct 30, 2024

For now, I can hardcode this information in the REMIX UI. However, the drawback is that revive change will also require an update to the REMIX IDE.

@xermicus
Copy link
Member Author

paritytech/revive#105

@xermicus
Copy link
Member Author

This will let the resolc binary display the full version info. But for remix, you should probably be able to read the version you are interacting with somewhere on the WebUI? And then we know what compiler backend is deployed?

@smiasojed
Copy link
Contributor

smiasojed commented Oct 30, 2024

I would need to add such functionality. Now REMIX uses solc version only as it has internal logic based on it.
We could add resolc version to contract metadata - now we have there:

solc_zkvm_edition:
zk_version: 0.1.0

@xermicus
Copy link
Member Author

Ah okay. Yeah let me change the metadata. i think we can also add the commit hash there.

@athei
Copy link
Member

athei commented Oct 31, 2024

You don't need approval to merge in this repo. Just merge when you think it is ready.

@xermicus
Copy link
Member Author

xermicus commented Oct 31, 2024

Ok good know, thanks

(will wait with this as we will release dev-5 today already)

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus xermicus changed the title sync known revive issues with the latest resolc release 0.1.0-dev-4 sync known revive issues with the latest resolc release 0.1.0-dev.5 Oct 31, 2024
@xermicus xermicus merged commit 615cfa2 into master Oct 31, 2024
3 checks passed
@xermicus xermicus deleted the cl/resolc-0.1.0-dev-4 branch October 31, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants