Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] add tpl to init containers #333

Merged
merged 4 commits into from
Mar 25, 2024
Merged

[node] add tpl to init containers #333

merged 4 commits into from
Mar 25, 2024

Conversation

BulatSaif
Copy link
Contributor

@BulatSaif BulatSaif commented Mar 18, 2024

There are situations when it is useful to run a node with a custom chainspec. In the current approach, you need to generate the chainspec, upload it, and set CustomChainspecUrl, or you need a custom binary. An alternative approach is to use an init container to generate and store the chain-spec in /chain-data/chainspec.json. In this PR, I added some changes which may be useful for doing so. It is now possible to mount a custom chainspec as a configmap as well.

Changes:

  1. added tpl to containers and initcontainers
  2. added extra ports to service
  3. added option to use custom chainspec file.

@BulatSaif BulatSaif self-assigned this Mar 18, 2024
@BulatSaif BulatSaif marked this pull request as ready for review March 20, 2024 18:13
@PierreBesson
Copy link
Contributor

Could you add a test of an example custom chainspec in the ci/ values file ?

@BulatSaif BulatSaif force-pushed the bs/update-node-helmchart branch from 63e06d4 to 8ed5521 Compare March 25, 2024 15:07
@BulatSaif
Copy link
Contributor Author

BulatSaif commented Mar 25, 2024

Could you add a test of an example custom chainspec in the ci/ values file ?

I added examples/local-rococo, it is more visible in examples comparing to ci/.

@BulatSaif BulatSaif merged commit 9fe1c9e into main Mar 25, 2024
3 checks passed
@BulatSaif BulatSaif deleted the bs/update-node-helmchart branch March 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants