Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CI tests for macOS #13

Merged
merged 16 commits into from
Aug 8, 2024
Merged

added CI tests for macOS #13

merged 16 commits into from
Aug 8, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Aug 7, 2024

Added a matrix to run the CI jobs, using both ubuntu-latest and macos-latest.

@Bullrich Bullrich requested a review from rzadp August 7, 2024 09:36
more debug log

more test

another test

trying with brackets
@rzadp
Copy link
Contributor

rzadp commented Aug 8, 2024

Once we have it working, could you remember to add the same to the other two?

Copy link
Contributor

@rzadp rzadp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (after removing the disk space diagnostics)

@Bullrich Bullrich enabled auto-merge August 8, 2024 11:27
@Bullrich Bullrich merged commit 331e79d into master Aug 8, 2024
4 checks passed
@Bullrich Bullrich deleted the ci/macos branch August 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants