Merge branch 'develop' into pgrete/pmd-output

parthenon-hpc-lab · Nov 29, 2024 · dfbcb27 · dfbcb27
2 parents d064f03 + 2fc423a
commit dfbcb27
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@
 - [[PR 1172]](https://github.com/parthenon-hpc-lab/parthenon/pull/1172) Make parthenon manager robust against external MPI init and finalize calls
 
 ### Fixed (not changing behavior/API/variables/...)
+- [[PR 1211]](https://github.com/parthenon-hpc-lab/parthenon/pull/1211) remove inline from WriteTaskGraph
 - [[PR 1188]](https://github.com/parthenon-hpc-lab/parthenon/pull/1188) Fix hdf5 output issue for metadata none variables, update test.
 - [[PR 1170]](https://github.com/parthenon-hpc-lab/parthenon/pull/1170) Fixed incorrect initialization of array by a const not constexpr
 - [[PR 1189]](https://github.com/parthenon-hpc-lab/parthenon/pull/1189) Address CUDA MPI/ICP issue with Kokkos <=4.4.1

diff --git a/src/tasks/tasks.cpp b/src/tasks/tasks.cpp
@@ -70,8 +70,8 @@ bool Task::ready() {
   return go;
 }
 
-inline std::ostream &WriteTaskGraph(std::ostream &stream,
-                                    const std::vector<std::shared_ptr<Task>> &tasks) {
+std::ostream &WriteTaskGraph(std::ostream &stream,
+                             const std::vector<std::shared_ptr<Task>> &tasks) {
 #ifndef HAS_CXX_ABI
   std::cout << "Warning: task graph output will not include function"
                "signatures since libcxxabi is unavailable.\n";