-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leapfrog fix #1206
Leapfrog fix #1206
Conversation
OK there's an additional issue which is that our |
This should be fixed with Kokkos 4.4 which has support for sorting on hip (though the interface would need to be updated). |
Yes agreed, I can make a separate WIP PR to switch to |
* Missing send size init * cleanup, CHANGELOG * verbose CI * further CI debugging * This should be working... * This should be fixed... but I get a segfault on GPU * Is it my AMD GPU thats wrong? * Missing a return statement * retest * Oops missing statement * Revert test * revert workflow
PR Summary
The
particle_leapfrog_outflow
test is currently breaking CI intermittently.I think the issue is that, for zero particles on a rank, we don't initialize all
send_size
s to0
so sometimes they're full of garbage. This PR seems to cycle correctly.PR Checklist