Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leapfrog fix #1206

Merged
merged 12 commits into from
Nov 8, 2024
Merged

Leapfrog fix #1206

merged 12 commits into from
Nov 8, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Nov 7, 2024

PR Summary

The particle_leapfrog_outflow test is currently breaking CI intermittently.

I think the issue is that, for zero particles on a rank, we don't initialize all send_sizes to 0 so sometimes they're full of garbage. This PR seems to cycle correctly.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@brryan brryan requested a review from alexrlongne November 7, 2024 15:53
@brryan brryan changed the title WIP: Leapfrog fix Leapfrog fix Nov 7, 2024
@brryan brryan requested a review from pdmullen November 7, 2024 16:14
@brryan
Copy link
Collaborator Author

brryan commented Nov 7, 2024

OK there's an additional issue which is that our sort() command is currently disabled for HIP. I'm going to see if I can't fix this

@pgrete
Copy link
Collaborator

pgrete commented Nov 7, 2024

OK there's an additional issue which is that our sort() command is currently disabled for HIP. I'm going to see if I can't fix this

This should be fixed with Kokkos 4.4 which has support for sorting on hip (though the interface would need to be updated).

@brryan
Copy link
Collaborator Author

brryan commented Nov 7, 2024

OK there's an additional issue which is that our sort() command is currently disabled for HIP. I'm going to see if I can't fix this

This should be fixed with Kokkos 4.4 which has support for sorting on hip (though the interface would need to be updated).

Yes agreed, I can make a separate WIP PR to switch to Kokkos::sort() after we upgrade parthenon to Kokkos 4.4

@brryan brryan enabled auto-merge (squash) November 8, 2024 01:44
@brryan brryan merged commit f2171ff into develop Nov 8, 2024
53 checks passed
acreyes pushed a commit to acreyes/parthenon that referenced this pull request Nov 14, 2024
* Missing send size init

* cleanup, CHANGELOG

* verbose CI

* further CI debugging

* This should be working...

* This should be fixed... but I get a segfault on GPU

* Is it my AMD GPU thats wrong?

* Missing a return statement

* retest

* Oops missing statement

* Revert test

* revert workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants