Simplifies PType's APIs #1658
Merged
Simplifies PType's APIs #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedquinn
force-pushed
the
v1-ptype-apis
branch
from
b36a420
to
f18117a
Compare
Removes deprecation notices on several PType APIs
johnedquinn
force-pushed
the
v1-ptype-apis
branch
from
f18117a
to
d77590e
Compare
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommendation
Since the diff is quite large, I'd recommend looking at the diff of each commit rather than the whole diff.
Relevant Issues
Closes #1489
Description
PType.Kindand converting all variants to static final integers.NUMERICto use precision/scale. Note that the change of NUMERIC to use BigDecimal will come later when updating Datum.PType#decimal()andPType#numeric()static methods.License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.