FIX: Deserialization of sized variable items #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only supporting the deserialization of unsized variable items (e.g. single values obtained through
var[0]
), although we also supported sized variable items through slices (e.g.var[1:5:2]
).The abstract representation allowed for serialization of these variable items but then deserialization failed. The easiest way to fix this was actually to add support for indexing variables with a list of indices (e.g.
var[[0, 1, 3]]
), so this hotfix actually introduces a small enhancement.VariableItem
by indexing aVariable
with a list of indices__len__
for sizedVariableItem
instances