Add from_abstract_repr to Device and VirtualDevice #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nataliejpg does this close your issue ? |
HGSilveri
reviewed
Sep 11, 2024
Comment on lines
+840
to
+841
| if isinstance(device, Device): | ||
| return device.to_virtual() |
There was a problem hiding this comment.
I think this is not a bad idea. Let's just add a Warning: section in the docstring to document this behaviour
tests/test_abstract_repr.py
Outdated
Comment on lines
232
to
251
| obj_str: str, | ||
| original_err: Type[Exception], | ||
| err_msg: str = "", | ||
| check_from_abstract_repr=False, | ||
| ) -> Exception: | ||
| with pytest.raises(DeserializeDeviceError) as exc_info: | ||
| deserialize_device(obj_str) | ||
|
|
||
| cause = exc_info.value.__cause__ | ||
| assert isinstance(cause, original_err) | ||
| assert re.search(re.escape(err_msg), str(cause)) is not None | ||
| func_to_test = [deserialize_device] | ||
| err_raised = [] | ||
| if check_from_abstract_repr: | ||
| func_to_test += [ | ||
| Device.from_abstract_repr, | ||
| VirtualDevice.from_abstract_repr, | ||
| ] | ||
| for func in func_to_test: | ||
| with pytest.raises(DeserializeDeviceError) as exc_info: | ||
| func(obj_str) | ||
| err_raised.append(exc_info) | ||
| for exc_info in err_raised: | ||
| cause = exc_info.value.__cause__ | ||
| assert isinstance(cause, original_err) | ||
| assert re.search(re.escape(err_msg), str(cause)) is not None |
There was a problem hiding this comment.
This is looking unnecessarily convoluted. Why not just make the function to test an argument to the function (potentially with the default being deserialize_device) and then do the test for the from_abstract_repr() outside of the function?
|
@MatthieuMoreau0 that's of interest for you as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_abstract_repr uses deserialize_device and checks the type of the returned device for it to match the class that generated it:
Should I keep this behaviour for VirtualDevice ?
Closes Have a method
from_abstract_reprin Device to deserialize an abstract Device #725