Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-32309)[PRO] test: migrate e2e cookieBanner with Factory #14557

Merged
merged 1 commit into from
Oct 16, 2024
Merged

(PC-32309)[PRO] test: migrate e2e cookieBanner with Factory #14557

merged 1 commit into from
Oct 16, 2024

Conversation

scolson-pass
Copy link
Contributor

@scolson-pass scolson-pass commented Oct 10, 2024 •
edited
Loading

But de la pull request

Migration de cookieBanner sans Cucumber et sans sandbox avec data Factory (comptes simples)

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a604071):

https://pc-pro-testing--pr14557-pc-32309-e2e-migrate-dt8ud9va.web.app

(expires Thu, 17 Oct 2024 10:33:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@scolson-pass scolson-pass force-pushed the PC-32309-e2e-migrate-cookieBanner branch from fd4f207 to 4d64029 Compare October 14, 2024 13:39
@scolson-pass scolson-pass self-assigned this Oct 14, 2024
@scolson-pass scolson-pass marked this pull request as ready for review October 14, 2024 14:25
Aliochka
Aliochka reviewed Oct 15, 2024
View reviewed changes
pro/cypress/e2e/migrations/cookieBanner.cy.ts Outdated Show resolved Hide resolved
pro/cypress/e2e/migrations/cookieBanner.cy.ts Outdated Show resolved Hide resolved
pro/cypress/e2e/migrations/cookieBanner.cy.ts Outdated Show resolved Hide resolved
pro/cypress/e2e/migrations/cookieBanner.cy.ts Outdated Show resolved Hide resolved
pro/cypress/e2e/migrations/cookieBanner.cy.ts Outdated Show resolved Hide resolved
pro/cypress/e2e/migrations/cookieBanner.cy.ts Outdated Show resolved Hide resolved
@scolson-pass scolson-pass force-pushed the PC-32309-e2e-migrate-cookieBanner branch from 4d64029 to 77b0ba8 Compare October 15, 2024 09:06
@scolson-pass
(PC-32309)[PRO] test: migrate e2e cookieBanner with Factory
a604071 
with factory

end

wip

Review fix + stepLog

review
@scolson-pass scolson-pass force-pushed the PC-32309-e2e-migrate-cookieBanner branch from a9848da to a604071 Compare October 15, 2024 10:22
@scolson-pass scolson-pass merged commit 4c5cf80 into master Oct 16, 2024
19 checks passed
@scolson-pass scolson-pass deleted the PC-32309-e2e-migrate-cookieBanner branch October 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdekoninck-pass xdekoninck-pass xdekoninck-pass approved these changes

@Aliochka Aliochka Aliochka approved these changes

Assignees

@scolson-pass scolson-pass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scolson-pass @Aliochka @xdekoninck-pass