-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-26279)[PRO] refactor: cleanup Offerer and Venue components #9862
Conversation
Visit the preview URL for this PR (updated for commit 30c2516): https://pc-pro-testing--pr9862-pc-26279-5k45gwyt.web.app (expires Sat, 30 Dec 2023 16:10:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça fait du bien de plus voir autant de props
hasNonFreeOffer, | ||
isFirstVenue, | ||
}: VenueProps) => { | ||
export const Venue = ({ offerer, venue, isFirstVenue }: VenueProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
f2c75e7
to
30c2516
Compare
But de la pull request
Refacto iso fonctionnelle qui déplace et simplifie des props dans le but de pouvoir réutiliser plus facilement pour la feature
La plupart des props déplacés n'avait pas de raison d'exister (vs juste descendre la
venue
ou l'offerer
) et pour les valeurs calculées et passées aux enfants le coût en perf est anecdotique (très peu d'AC ont plus de 5 lieux) de répéter le calcul dans les composants enfants.Tests possibles :
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-26279
Vérifications