Drop support for Python 2.7 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
========================================
Coverage 97.66% 97.66%
========================================
Files 4 2 -2
Lines 1114 557 -557
========================================
- Hits 1088 544 -544
+ Misses 26 13 -13 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Since pypi deployment did succeed yesterday, the version was updated to 2.5.3. https://pypi.org/project/pydorado/2.5.3 (although it still states support for 2.7) |
|
@wrightky feel free to merge anytime, my comment above was that you could potentially bump the version one minor increment to make sure the pypi page/deployment incorporates these changes if you plan to tag a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conda deployment failed, seems to be due to an attempted install on Python 2.7. Dropping all remaining mentions of the legacy version I could find.