Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: implement saveAs in a browser fashion way using URL.createObjectURL #81

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

FIX: implement saveAs in a browser fashion way using URL.createObjectURL #81

wants to merge 28 commits into from

Conversation

guidoschmidt
Copy link
Contributor

  • DEL/src/js/vendor: let's get rid of this oldie thing :)
  • ADD/src/tools/download.js: re-implement saveAs function
  • EDIT/js/core/Shader.js + js/GlslEditor.js: import new saveAs

Second PR to get saveAs back in

@guidoschmidt
FIX: implement saveAs in a browser fashion way using URL.createObjectURL
8957cb6 
- DEL/src/js/vendor: let's get rid of this oldie thing :)
- ADD/src/tools/download.js: re-implement saveAs function
- EDIT/js/core/Shader.js + js/GlslEditor.js: import new saveAs
@CodyJasonBennett CodyJasonBennett mentioned this pull request Oct 29, 2022
Closed
@guidoschmidt
Copy link
Contributor Author

@patriciogonzalezvivo @guidoschmidt
fix correct error handling
00f665a
@guidoschmidt
Adding Guido Schmidt fix for save as patriciogonzalezvivo@8957cb6
dde4cde
@guidoschmidt
no package-lock.json
ed64c19
@patriciogonzalezvivo @guidoschmidt
hint
5e01281
@patriciogonzalezvivo @guidoschmidt
push build
9978476
@guidoschmidt
adding hints and package-lock back
3629a15
@guidoschmidt
updating glslCanvas and autocomplate includes sooner
e91e318
@guidoschmidt
FIX: implement saveAs in a browser fashion way using URL.createObjectURL
302a82b 
- DEL/src/js/vendor: let's get rid of this oldie thing :)
- ADD/src/tools/download.js: re-implement saveAs function
- EDIT/js/core/Shader.js + js/GlslEditor.js: import new saveAs
@guidoschmidt
refactor: move to Vite
7595316
@patriciogonzalezvivo @guidoschmidt
fix correct error handling
e05a05a
@patriciogonzalezvivo @guidoschmidt
Adding Guido Schmidt fix for save as patriciogonzalezvivo@8957cb6
3477fdb
@patriciogonzalezvivo @guidoschmidt
no packege-lock.json
370ff06
@patriciogonzalezvivo @guidoschmidt
no package-lock.json
8304268
@patriciogonzalezvivo @guidoschmidt
hint
926f9ac
@patriciogonzalezvivo @guidoschmidt
push build
5b2dc84
@patriciogonzalezvivo @guidoschmidt
adding hints and package-lock back
29d649f
@patriciogonzalezvivo @guidoschmidt
updating glslCanvas and autocomplate includes sooner
7703ddc
@guidoschmidt
FIX: implement saveAs in a browser fashion way using URL.createObjectURL
a945359 
- DEL/src/js/vendor: let's get rid of this oldie thing :)
- ADD/src/tools/download.js: re-implement saveAs function
- EDIT/js/core/Shader.js + js/GlslEditor.js: import new saveAs
@CodyJasonBennett @guidoschmidt
refactor: move to Vite
3ea9a69
@patriciogonzalezvivo @guidoschmidt
hint
fb7b654
@patriciogonzalezvivo @guidoschmidt
push build
5163c4c
@guidoschmidt
Merge branch 'main' of https://github.com/patriciogonzalezvivo/glslEd…
495d914 
…itor
@guidoschmidt
EDIT/.gitignore: get rid of yarn.lock
09ddda5
@guidoschmidt
Merge branch 'main' of https://github.com/patriciogonzalezvivo/glslEd…
6400f07 
…itor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guidoschmidt @CodyJasonBennett @patriciogonzalezvivo