-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] Refactor and enhance with ID generation, trace linking, formatting, and export improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds in existing formatters
…nd type definitions
…nking method calls and returns
…nd ExportManager for improved trace data handling
…od name formatting, and parameter formatting; refactor BaseFormatter to extend TraceDataFormatter
…eration and enhance TraceLinker with logging for invalid links
patrick204nqh
added
the
enhancement
A new feature or an improvement to existing functionality.
label
Dec 28, 2024
…of ffi and nokogiri
…to use COVERAGE environment variable
patrick204nqh
added
approved
PRs that are approved and ready to merge.
and removed
in review
Pull requests currently under review.
labels
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
PRs that are approved and ready to merge.
enhancement
A new feature or an improvement to existing functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a series of improvements, refactors, and new features to enhance the functionality, maintainability, and usability.
Major Features
ID Generation:
IDGenerator
for centralized and reusable unique ID creation.TraceLinker
module, which adds robust logging for invalid links and better trace correlation.Formatting Enhancements:
KeyValueFormatter
for structured trace formatting.ValueTruncator
to handle large trace data efficiently.Export Improvements:
Refactors
LoggingManager
for centralized logging.ExportManager
for modular export handling.BaseFormatter
to extend the newTraceDataFormatter
.ValueTruncator
and other components for stricter length validation and RBS type definitions.Dependency Updates
Steep
gem for type checking, ensuring better static analysis.Miscellaneous Enhancements
TraceViz
module, including adapters, collectors, and tracers, with RBS signatures.Bug Fixes
truncate_length
to ensure it is always an integer, resolving potential type-related issues.Type of Change
Check all that apply:
How Has This Been Tested?
The following tests and validations have been performed to ensure stability and correctness:
bundle exec rspec
to confirm all tests pass.Steep
gem.Checklist
README.md
andCHANGELOG.md
.Deployment Notes
Related Issues
Screenshots (if applicable)
N/A