-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 support 🚀 and Laravel 6, 7 and 8 support #342
Conversation
tortuetorche
commented
Dec 1, 2020
- Add PHP 7.3, 7.4 and 8.0 support
- Add Laravel 6, 7 and 8 support
- Update phpspec tests
- Drop PHP 5.6, 7.0 and 7.1 support
- Drop Laravel 5 support
* Add PHP 7.3, 7.4 and 8.0 support * Add Laravel 6, 7 and 8 support * Update phpspec tests * Drop PHP 5.6, 7.0 and 7.1 support * Drop Laravel 5 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good - though does #320 still apply?
- 7.2 | ||
- 7.3 | ||
- 7.4 | ||
- 8.0snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised that Travis doesn't have a proper PHP8 thing already!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I checked, they don't! But soon I hope 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to wait the php-build
1.0.0 release I think...
References:
In fact - there's a lot of tickets about incompatabilities with laravelcollective/html - how many of them still apply? |
Good catch, I think we can remove the Reference: https://laravel.com/docs/5.4/upgrade |
FYI build (from my fork) passed: https://travis-ci.com/github/tortuetorche/bootstrapper/builds/205628104 By the way, you should migrate from the legacy https://travis-ci.org to the new https://travis-ci.com, to get faster builds 👍 |
I need to do more manual tests to answer you |
Because it was useful only for Laravel <= 5.3 Reference: https://laravel.com/docs/5.4/upgrade#sessions See: patricktalmadge#320
Done! Build (from my fork) passed: https://travis-ci.com/github/tortuetorche/bootstrapper/builds/205632538 |
I'd love to, but it looks like because this is still under @patricktalmadge's name it's something they'd have to do. With the amount of work that gets done on Bootstrapper on a daily basis (I no longer use Laravel on a day to day basis), it's probably not worth it :( |
Good news, I tested the |
Awesome, I'll merge this later tonight and tag it for a release. Thanks so much for your contribution! |
@PatrickRose You've have done much much more than me on this package, so thanks to you!
You've have done much much more than me on this package, so big thank to you! |
And tagged - thanks again! |
FYI, the 5.12.0 tag isn't present in Packagist (https://packagist.org/packages/patricktalmadge/bootstrapper) "require": {
//...
"patricktalmadge/bootstrapper": "dev-master",
//...
}, |
@PatrickRose (or @Anahkiasen) I think you can do a manual update on https://packagist.org/packages/patricktalmadge/bootstrapper If you login with your GitHub account, then you can click on the |
I've done the update, sorry about that! |