Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review trainingCard.css styles for replacing custom styles with existing styling options or tokenization #4023

Closed
wise-king-sullyman opened this issue May 14, 2024 · 1 comment · Fixed by #4127
Closed

Review trainingCard.css styles for replacing custom styles with existing styling options or tokenization #4023

wise-king-sullyman opened this issue May 14, 2024 · 1 comment · Fixed by #4127
Assignees
@nicolethoen
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

wise-king-sullyman commented May 14, 2024 •
edited by nicolethoen
Loading

Followup from #4011

Per @mcoker in this comment:

I wonder if we could get rid of some of these styles. If not, we should probably tokenify these styles.

I think we can remove the whole design training w/ sketch page
@wise-king-sullyman wise-king-sullyman mentioned this issue May 14, 2024
Merged
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 14, 2024
@jessiehuff jessiehuff added this to the Penta beta release milestone Jun 4, 2024
@jessiehuff jessiehuff moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen moved this from Backlog to Not started in PatternFly Issues Jun 28, 2024
@nicolethoen nicolethoen self-assigned this Jul 8, 2024
@nicolethoen nicolethoen mentioned this issue Jul 9, 2024
Merged
@nicolethoen nicolethoen linked a pull request Jul 9, 2024 that will close this issue
fix: clean up community and trainging card css #4127
Merged
@nicolethoen nicolethoen moved this from Not started to PR Review in PatternFly Issues Jul 9, 2024
@nicolethoen
Copy link
Collaborator

closed by #4127

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
None yet
Projects
PatternFly Issues
Archived in project
PatternFly Extensions
Status: Needs triage
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix: clean up community and trainging card css nicolethoen/patternfly-org
4 participants
@wise-king-sullyman @nicolethoen @jessiehuff @andrew-ronaldson