fix: clean up community and trainging card css #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 9, 2024
Review community.md for removing utility classes, potentially replacing custom elements/styles
#4021
Closed
|
@nicolethoen The headings look a little close to the cards, not sure if a 
The footer button also makes the text look slightly indented--should we add Otherwise, looks great! (of course, the content itself could use updates, but we could open a followup if that's something we want to revisit later) |
|
+1 to @edonehoo's comments. The Start > button needs a space between text and icon. Other than that good stuff all around. |
|
easy fixes! i'm on it! :) |
nicolethoen
force-pushed
the
clean_up_community_training_card_css
branch
from
2ca021f
to
298b635
Compare
edonehoo
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4021
Closes #4023
A major improvement to training cards: https://patternfly-org-pr-4127-site.surge.sh/training/html/
but open to more suggestions