Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(flex): expands design guidelines for flex layout. #3667

Merged
merged 12 commits into from
Oct 4, 2023
Merged

docs(flex): expands design guidelines for flex layout. #3667

merged 12 commits into from
Oct 4, 2023

Conversation

edonehoo
Copy link
Collaborator

closes #3581

@edonehoo edonehoo self-assigned this Jul 28, 2023
@edonehoo edonehoo marked this pull request as draft July 28, 2023 15:43
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 28, 2023 •
edited
Loading

Preview: https://patternfly-org-pr-3667-site.surge.sh

@edonehoo edonehoo changed the title docs: expands design guidelines for flex layout. docs(flex): expands design guidelines for flex layout. Aug 8, 2023
@edonehoo edonehoo marked this pull request as ready for review August 25, 2023 15:48
@edonehoo
Copy link
Collaborator Author

@lboehling @mmenestr

mmenestr
mmenestr reviewed Aug 29, 2023
View reviewed changes
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/flex.md Outdated

The flex layout is based on the [CSS "flex" properties](https://www.w3schools.com/cssref/css3_pr_flex.php), which help determine how a flex item will grow or shrink to fit a containers available space. These properties allow for variation in the implementation and appearance of flex layouts.

Most of the flex layout variations are available at our standard [breakpoints](/developer-resources/global-css-variables#breakpoint-variables-and-class-suffixes). In the future, we plan to apply these modifiers via [ResizeObserver](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the developer-resources link doesn't work

@mmenestr
Copy link
Collaborator

@edonehoo if this is ready to merge lmk! I approved it :)

@edonehoo
Copy link
Collaborator Author

@mmenestr it's ready to merge, ty!

@evwilkin evwilkin merged commit a2df242 into patternfly:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenestr mmenestr mmenestr approved these changes

@lboehling lboehling Awaiting requested review from lboehling

Assignees

@edonehoo edonehoo

Labels
Content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance design guidelines for our Layouts pages - Flex
4 participants
@edonehoo @patternfly-build @mmenestr @evwilkin