docs(grid): expands design guidelines for grid layout. #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edonehoo
changed the title
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Aug 29, 2023
|
|
||
| By adjusting the column span, row span, and order at various [breakpoints](/developer-resources/global-css-variables#breakpoint-variables-and-class-suffixes), you can adapt the grid for different screen sizes. | ||
|
|
||
| [A couple of image examples?] |
There was a problem hiding this comment.
As a designer, yes I would add image examples to understand. But as a dev, maybe linking to those variables is enough? I'll let Lucia opine haha
There was a problem hiding this comment.
I opted to remove that section, because I don't know how to visualize that info, but lmk if you think it's important to re-add!
|
Lmk how these images work lol I kind of scrapped them together |
mmenestr
requested changes
Sep 11, 2023
|
|
||
| Grid items can be ordered in a number of ways to create groups. The span value of all grid items must equal 12, but this can be achieved by combining different section sizes. | ||
|
|
||
| However, by following the rule that all items should span up to 12, the grid can easily be modified and readjusted: |
There was a problem hiding this comment.
this is small but for some reason the "however" feels wrong here, cause you already have the "but this can be achieved..." which already has the positive spin to having to equal 12.
There was a problem hiding this comment.
that's a good catch - I agree! I updated this phrasing, lmk what you think
edonehoo
commented
Sep 12, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
edonehoo
commented
Sep 12, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/grid.md
Outdated
Show resolved
Hide resolved
…delines/layouts/grid.md
…delines/layouts/grid.md
mmenestr
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3585