docs(split): expands design guidelines for split layout. #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edonehoo
changed the title
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/split.md
Outdated
Show resolved
Hide resolved
edonehoo
commented
Aug 25, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/split.md
Outdated
Show resolved
Hide resolved
|
@lboehling @mmenestr initial drafts of the layouts design guidelines are ready if you two want to take a look & give feedback! I'll tag you on all of them just fyi when you get a lot of notifs. I couldn't find images for most layouts (and will need to confirm the ones I found with devs), so if you have ideas on where to grab some I'm all ears |
mmenestr
reviewed
Sep 11, 2023
|
|
||
| ### Multiple items that fill space | ||
|
|
||
| You can specify which split item fills the remaining horizontal space in the layout. More than one item can be set to fill, as, and they will share the remaining space equally. |
There was a problem hiding this comment.
I don't understand this sentence haha the "can be set to fill, as, and"
mmenestr
requested changes
Sep 11, 2023
edonehoo
commented
Sep 12, 2023
packages/documentation-site/patternfly-docs/content/design-guidelines/layouts/split.md
Outdated
Show resolved
Hide resolved
…delines/layouts/split.md
mmenestr
previously approved these changes
Sep 27, 2023
mmenestr
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3587