Skip to content

Commit

Permalink
fix: fixed fatal repetition of upper Cholesky to LU banded storage co…
Browse files Browse the repository at this point in the history
…nversion in log pseudodet computation
  • Loading branch information
MothNik committed May 11, 2024
1 parent fcb957b commit 0037c71
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions chemotools/utils/whittaker_base/initialisation.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def get_penalty_log_pseudo_det(n_data: int, differences: int, dtype: Type) -> fl
"""

# the flipped penalty matrix D @ D.T is computed
_, flipped_penalty_matb = get_squ_fw_diff_mat_banded(
flipped_l_and_u, flipped_penalty_matb = get_squ_fw_diff_mat_banded(
n_data=n_data,
differences=differences,
orig_first=True,
Expand All @@ -162,9 +162,6 @@ def get_penalty_log_pseudo_det(n_data: int, differences: int, dtype: Type) -> fl

# the pseudo-determinant is computed from the partially pivoted LU decomposition
# of the flipped penalty matrix
flipped_l_and_u, flipped_penalty_matb = (
bla.conv_upper_chol_banded_to_lu_banded_storage(ab=flipped_penalty_matb)
)
log_pseudo_det_sign, log_pseudo_det = bla.slogdet_lu_banded(
lub_factorization=bla.lu_banded(
l_and_u=flipped_l_and_u,
Expand Down

0 comments on commit 0037c71

Please sign in to comment.