-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future #27
Open
paudetseis
wants to merge
59
commits into
master
Choose a base branch
from
future
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Future #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b54c6d5. Remove logging module
…data. Useful for plotting data gaps.
* Support for optimal waterlevel * Compacter and easier binning and deconvolution routines
resolve conflicts
This avoids conflic with clients that do not support attach_response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last few large commits, the code base was modified in the following ways:
deconvolve
was split up intocalc_spectra
, which stores the cross-spectra (numerator and denominator) as new attributes of theRFData
object, and a new method calleddeconvolve
, which uses the pre-calculated spectra in the spectral ratio. The traces can be normalized by the pre-event noise amplitude[(trace.data - meanNoise)/stdNoise for trace in rfdata.data]
. This is useful for the stacking of events with different magnitudes.binning.baz_slow_bin
was edited to take in either real or complex data, in order to use the (possibly complex) spectra during binning.plotting.panel
function to plot binned RFs as a panel sorted by back-azimuth and slowness values. It is used in bothrfpy_calc_simdec
andrfpy_plot
below.I made changes to the scripts in the following ways:
rfpy_calc
was split up intorfpy_get_data
andrfpy_calc
, where the data download is done first with minimal pre-processing. The coderfpy_calc
is now similar to whatrfpy_recalc
used to be, and that script became obsolete and was removed.rfpy_calc_simdec
that loads all ZNE data and performs simultaneous deconvolution. This script stores all (auto- and cross-) spectra into a stream and then bins them according to BAZ and slowness. The RFs are then calculated by performing the spectral ratio using the summed quantities. At this time it does not save or write to file any of the final RFs.rfpy_plot
now allows plotting as a panel of RF bins (obtained fromrfpy_calc
). The "panel" option is called whenever the user specifies both--nbaz
and--nslow
as arguments.After going through all this trouble, it appears that the simultaneous deconvolution does not produce any noticeable improvement, at least visually.
To test both versions, go through these steps:
.
A few things to note:
Do not merge yet - we need to create an "old" branch that we could revert to just in case