New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unknown psbt keypairs #119

Open

louisinger wants to merge 3 commits into paulmillr:main from louisinger:unknown-psbt

louisinger commented Dec 31, 2024

Support Unknown PSBT Key-Pairs

Changes

Modified the mergeKeyMap function to preserve unknown PSBT key-pairs when they are explicitly set in the "unknown" array
Add bip174-psbt: PSBT unknown keys test case

Technical Details

Previously, all unknown keys were being removed during the merge operation
Now, the 'unknown' array is preserved while other unrecognized keys are still cleaned up
Added comprehensive tests to ensure unknown key-pairs are correctly:
- Added to PSBT inputs and outputs
- Preserved during serialization/deserialization cycles

it closes #118

louisinger added 3 commits

December 31, 2024 12:05


          support unknown psbt keypairs

7a83a77


          rename testcase

293af55


          cleaning comment

527514c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet