-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nucleofind Build #54
Draft
Dialpuri
wants to merge
16
commits into
paulsbond:master
Choose a base branch
from
Dialpuri:nucleofind-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Nucleofind Build #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement new nucleic acid building tools: NucleoFind for map prediction and NucleoFindBuild for structure refinement. Replace the Nautilus step with NucleoFind in the modelcraft X-ray pipeline.
Performed code reformatting in nucleofind_build.py file for improving readability and consistency. Adjusted indents in the constructor of the NucleoFindBuild class and also corrected the identation for elements inside the NucleoFindBuildResult return block.
Updated the superclass in Refmac.py constructor from 'refmac5' to 'refmacat'. Additionally, removed unnecessary comments from modelcraftxray.py file to improve code readability.
This commit introduces a post-install command in setup.py and increases the version from 3.6.0 to 5.0.0. It also adds nucleofind to the requirements and the installation dependencies of the package.
The previously unnamed post-installation method `__post_install` in the setup.py file was renamed to `install_nucleofind_models`. This change was made to reflect that the method is specifically responsible
This commit introduces an import of the install command from setuptools in setup.py. This is a crucial addition to properly handle package installation during the set up process.
Added os import
Previously commented-out code for sugar and base maps has been reactivated. Adjusted file paths and arguments to properly handle sugar and base maps during processing. This enhances the functionality to include additional map types in the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening pull request to add NucleoFind to ModelCraft