Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve experience for Windows users #33

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Improve experience for Windows users #33

merged 2 commits into from
Oct 25, 2024

Conversation

blairconrad
Copy link
Contributor

No description provided.

@blairconrad
fix: Use shutil.copytree instead of cp
6037911 
Windows environments may not have cp
@blairconrad
fix: Use shutil.rmtree instead of rm
f0ebeac 
Windows environments may not have rm
@blairconrad
Copy link
Contributor Author

blairconrad commented Oct 25, 2024 •
edited
Loading

Hey. We talked about using cp. I also found rm, but didn't discuss before adding the commit and pushing.

Supposedly I should run make test to test, but... I have no make in Windows proper. It seemed to work in WSL though.

pawamoy
pawamoy approved these changes Oct 25, 2024
View reviewed changes
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good 🙂

@blairconrad
Copy link
Contributor Author

I think test-project-ci is stuck. Perhaps because it's run from a PR and I have no GH_TOKEN?

@pawamoy
Copy link
Owner

pawamoy commented Oct 25, 2024

Huh, weird, I thought it would be using my own CI and therefore the token would be set?

@pawamoy
Copy link
Owner

pawamoy commented Oct 25, 2024

Anyway, I canceled the workflow. Merging!

@pawamoy pawamoy merged commit ece7662 into pawamoy:main Oct 25, 2024
17 of 21 checks passed
@blairconrad
Copy link
Contributor Author

blairconrad commented Oct 25, 2024 •
edited
Loading

Huh, weird, I thought it would be using my own CI and therefore the token would be set?

I think there are barriers in place for security. Letting my (not-yet-merged) code use your GH_TOKEN is danger!

Thanks for the merge!

@blairconrad blairconrad deleted the better-windows-experience branch October 25, 2024 15:17
@pawamoy
Copy link
Owner

pawamoy commented Oct 25, 2024

Ha, yeah, makes sense indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blairconrad @pawamoy