Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements for GM handling #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fgrsnau
Copy link

@fgrsnau fgrsnau commented Apr 10, 2018

This PR handles two things:

  • It allows to save (reparametrized) GMs in OpenGM container format (using ExplicitFunctions).
  • Tweaks ProblemConstructor to match LP_MPs interface (only small inconsistency I recognized during writing temporary code).

Saving GMs is a bit complicated, as some models have TripletFactors and some have not. If you have better ideas than introducing a MrfHasTripletFactors trait, please let me know :)

@fgrsnau
Copy link
Author

fgrsnau commented Apr 17, 2018

I replaced the TripletFactor trait by a constexpr method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant