bugfix/PP-13303: before delete gateway check transaction too

payrexx · Nov 29, 2024 · 3a06ecb · 3a06ecb
1 parent 1b0addc
commit 3a06ecb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/PayrexxPaymentGatewaySW6/src/Handler/PaymentHandler.php b/PayrexxPaymentGatewaySW6/src/Handler/PaymentHandler.php
@@ -161,7 +161,6 @@ public function pay(AsyncPaymentTransactionStruct $transaction, RequestDataBag $
         if (in_array($paymentMean, ['sofortueberweisung_de', 'postfinance_card', 'postfinance_efinance'])) {
             throw new Exception('Unavailable payment method error');
         }
-
         // Create Payrexx Gateway link for checkout and redirect user
         try {
             $payrexxGateway = $this->payrexxApiService->createPayrexxGateway(

diff --git a/PayrexxPaymentGatewaySW6/src/Service/PayrexxApiService.php b/PayrexxPaymentGatewaySW6/src/Service/PayrexxApiService.php
@@ -209,7 +209,7 @@ public function deletePayrexxGateway(string $salesChannelId, int $gatewayId): vo
 
         $payrexx = $this->getInterface($salesChannelId);
         $gateway = $this->getPayrexxGateway($gatewayId, $salesChannelId);
-        if ($payrexx && $gateway && !$gateway->getInvoices()) {
+        if ($payrexx && $gateway && !$this->getTransactionByGateway($salesChannelId, $gatewayId)) {
             try {
                 $payrexx->delete($gateway);
             } catch (\Payrexx\PayrexxException $e) {