Txi optics veto #28
Merged
Txi optics veto #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Nov 5, 2024
| FFO_RIX_TXI_OPTICS : FB_FastFault :=( | ||
| i_Desc := 'Fault when MR1K1 is IN while a TXI Optics is in (either MR1K3 and MR2K3)', | ||
| FFO_RIX_TXI_OPTICS : FB_FastFault :=(i_DevName := 'PMPS Arbiter', | ||
| i_Desc := 'Fault when MR1K1 is IN while a TXI Optics is IN (Check MR1K3 and MR2K3)', |
There was a problem hiding this comment.
I like the updated names and descriptions 👍
ZLLentz
reviewed
Nov 5, 2024
Comment on lines
+117
to
+118
| cMR1K3_IN_UpperLimit : UDINT := 108500000 + 10000000; | ||
| cMR1K3_IN_LowerLimit : UDINT := 108500000 - 10000000 ; |
There was a problem hiding this comment.
Is there a reference for these encoder count changes?
It is not mentioned in the PR description.
There was a problem hiding this comment.
https://jira.slac.stanford.edu/browse/ECS-5650 I think its in the comments here.
There was a problem hiding this comment.
Could use better documentation here, but 10,000 microns specified as delta converted nano here.
There was a problem hiding this comment.
I'm going to add "Double the MR1K3 IN position's encoder count delta from 5,000 microns to 10,000 microns as per https://jira.slac.stanford.edu/browse/ECS-5650" to the PR description, then I'm going to approve.
ZLLentz
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIX FFO dev name and description
Double the MR1K3 IN position's encoder count delta from 5,000 microns to 10,000 microns as per https://jira.slac.stanford.edu/browse/ECS-5650
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)