add preset support for SQR1 #1255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix isort
ZLLentz
reviewed
Jun 27, 2024
|
|
||
| if preset_pos is not None: | ||
| axis_list = [self.x, self.y, self.z, self.rz, self.ry, self.rz] | ||
| if any(hasattr(a.presets.positions, preset_pos) for a in axis_list): |
There was a problem hiding this comment.
Is this intended to be all instead of any, to force all the presets to exist before moving?
ZLLentz
reviewed
Jun 27, 2024
| ry_sp = (getattr(self.ry.presets.positions, preset_pos)).pos | ||
| rz_sp = (getattr(self.rz.presets.positions, preset_pos)).pos | ||
| else: | ||
| logger.error('One of the axes is missing the desired state.') |
There was a problem hiding this comment.
should this return or raise as well in the error state to prevent the rest of the function from running?
ZLLentz
reviewed
Jun 27, 2024
ZLLentz
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Side note: the new functionality you've added here is unit-testable if you have the time
tangkong
reviewed
Jun 27, 2024
| @@ -0,0 +1,30 @@ | |||
| IssueNumber Title | |||
There was a problem hiding this comment.
did you run the script to generate this file? I'm surprised the filename is standard but the title here isn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add preset support for SQR1 device
Motivation and Context
James Cryan asked for preset feature so he can move lamp sqr1 to predefined positions where beam focus is the best
How Has This Been Tested?
tested using hutch-python with TMO LAMP SQR1
Where Has This Been Documented?
Pre-merge checklist