Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making ExitSlits subclass with FDQ component, only for SL1K2 for now #1307

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KaushikMalapati
Copy link
Contributor

@KaushikMalapati KaushikMalapati commented Nov 13, 2024

Description

ExitSlitsFDQ has an FDQ component so we can see flow meter readings on the typhos screen for SL1K2. I did not name this SL1K2 in case an ExitSlits+FDQ class is ever wanted in the future

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-6745

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@KaushikMalapati KaushikMalapati marked this pull request as ready for review November 13, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant