Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add a newline at end of filestore json file #63

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Jul 18, 2024

Description

Add a blank newline whenever writing the filestore .json file

Motivation and Context

Stumbled into this. The json would fail pre-commit checks every time we tried to commit it. While infrequent this is something that's easily avoided.

Without this, we would fail pre-commit

How Has This Been Tested?

Interactively

Where Has This Been Documented?

This PR

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong merged commit eb09405 into pcdshub:master Jul 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants