Fix sorting of proxy_map in PDMPyPIClient #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 112 112
Lines 11351 11352 +1
Branches 2473 2473
=======================================
+ Hits 9683 9684 +1
Misses 1140 1140
Partials 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sort proxy_map after constructing URLPatterns. URLPattern has logic to make more specific patterns sort first. Current code instead sorts URLs as strings, which orders them lexicographically. This means that URLs from `no_proxy` usually sort *after* URLs from `all_proxy` and so `no_proxy` settings have no effect. Fixes pdm-project#3254
eltoder
force-pushed
the
feature/session-proxy-sort
branch
from
5e2dfe5
to
a4a7d3b
Compare
frostming
approved these changes
Nov 5, 2024
frostming
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sort proxy_map after constructing URLPatterns. URLPattern has logic to make more specific patterns sort first. Current code instead sorts URLs as strings, which orders them lexicographically. This means that URLs from `no_proxy` usually sort *after* URLs from `all_proxy` and so `no_proxy` settings have no effect. Fixes #3254 Signed-off-by: Frost Ming <me@frostming.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
Sort proxy_map after constructing URLPatterns. URLPattern has logic to make more specific patterns sort first. Current code instead sorts URLs as strings, which orders them lexicographically. This means that URLs from
no_proxyusually sort after URLs fromall_proxyand sono_proxysettings have no effect.Fixes #3254