Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit post_lock after writing pyproject.toml and pdm.lock in add… #3291

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jantrienes
Copy link
Contributor

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

New lockfile is written before post_lock is emitted. Implementation analogous to #1225
Fixes #3285.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (3110fce) to head (096356a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
- Coverage   85.33%   85.32%   -0.01%     
==========================================
  Files         112      112              
  Lines       11402    11402              
  Branches     2487     2487              
==========================================
- Hits         9730     9729       -1     
- Misses       1143     1144       +1     
  Partials      529      529              
Flag Coverage Δ
unittests 85.12% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit d1dc03d into pdm-project:main Nov 15, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit post_lock after writing pyproject.toml and pdm.lock
2 participants