fix: renew the session token when the token expires #683
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MqllR
requested review from
igungor and
sonmezonur
and removed request for
a team
MqllR
force-pushed
the
token_renew_token
branch
3 times, most recently
from
e98687f to
3e46e7e
Compare
MqllR
force-pushed
the
token_renew_token
branch
from
3e46e7e to
6706169
Compare
|
this is also an issue on our side and could speed up the review & release process? thank you. |
cynix
reviewed
Jan 22, 2024
storage/s3.go
Outdated
|
|
||
| useSharedConfig := session.SharedConfigEnable | ||
| useSharedConfig := session.SharedConfigDisable |
|
+1, this would be great to have! |
|
@MqllR does the error only happen if s5cmd runs for more than hour? or it happens when trying to run short s5cmd on pod that is older than an hour? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #678
In a Kubernetes context, when running a very long process, we can easily fall into the
ExpiredTokenerror. In order to not introduce any performance degradation, I propose to keep to global variable caching the session token but clear it when catching this specific error. The session will be renewed by reading again the projected volume/var/run/secrets/eks.amazonaws.com/serviceaccount/token.