-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Update AWS SDK #684
vendor: Update AWS SDK #684
Conversation
sso_session
setup aws-sdk-go@1.44.298sso_session
setup
Just ran into this myself. Please review and cut this into a new release. |
Hi @igungor, can we get this merged? Thanks 🙏 |
Is there any update to this PR? Really looking forward to supporting S3 Express! |
Hi @ahmethakanbesel, any change for getting it merged? |
Closes #726. |
Hi, thanks for your contribution. Can you please follow the style guide in the PR title, since the title will be the commit message in the master branch. |
Done |
Hi, with the following go build:
When run
The following diff occurs. diff --git a/go.sum b/go.sum
index cf4b72f..53f6cf4 100644
--- a/go.sum
+++ b/go.sum
@@ -1,6 +1,5 @@
github.com/VividCortex/ewma v1.2.0 h1:f58SaIzcDXrSy3kWaHNvuJgJ3Nmz59Zji6XoJR/q1ow=
github.com/VividCortex/ewma v1.2.0/go.mod h1:nz4BbCtbLyFDeC9SUHbtcT5644juEuWfUAUnGx7j5l4=
-github.com/aws/aws-sdk-go v1.44.256 h1:O8VH+bJqgLDguqkH/xQBFz5o/YheeZqgcOYIgsTVWY4=
github.com/aws/aws-sdk-go v1.44.256/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
github.com/aws/aws-sdk-go v1.44.298 h1:5qTxdubgV7PptZJmp/2qDwD2JL187ePL7VOxsSh1i3g=
github.com/aws/aws-sdk-go v1.44.298/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI= The same diff occurs with |
61d53cf
to
162524c
Compare
Fixed |
162524c
to
911be65
Compare
#684 shows that if the vendor and the vendor generated by the tidy&vendor pipeline has diffs, we don't fail in the CI, but we should. This PR adds the check to the Makefile. --------- Co-authored-by: Deniz Surmeli <denizsurmeli@peak.com>
Hi, this is a simple change - I have a setup with AWS SSO, specifically
sso_session
(docs).It got implemented in the AWS Go SDK fairly recently aws/aws-sdk-go#4885 - v1.44.298
Since it's just a patch version upgrade, it was just a simple matter of bumping the version.
Thanks