Introduce a flag to preserve timestamps of files and preserve file ownership #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah/chore/update
Ahuge
requested review from
igungor and
sonmezonur
and removed request for
a team
|
Linked to #532 as well |
Ahuge
force-pushed
the
ah/chore/update
branch
2 times, most recently
from
11724a7 to
a0fc23a
Compare
|
Hold on this, I'll be rebasing and resubmitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a wrap up of #534 plus a flag to preserve file ownership.
This has been rebased off of master as well.
We are implementing a flag that when activated will record and store ctime, mtime, and atime in S3 as metadata on the object.
When pulling files down, if that data exists, we will set it on the files as well.
Linux & Darwin don't appear to allow setting of ctime, however atime and mtime are preserved.
Windows does allow us to set ctime, mtime, and atime, however they are actually referred to as CreationTime, LastAccessTime, and LastWriteTime.
The
--preserve-ownershipflag will query the user and group and store that in S3 as metadata.On Windows this stores the SID, on linux this stores the uid/gid.
Please let me know if you have feedback on this PR.
Thanks!