migrate webview impl to use updated library

pebble-dev · May 28, 2024 · 6b6d2eb · 6b6d2eb
1 parent c275e02
commit 6b6d2eb
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/android/app/src/main/kotlin/io/rebble/cobble/bluetooth/DeviceTransport.kt b/android/app/src/main/kotlin/io/rebble/cobble/bluetooth/DeviceTransport.kt
@@ -61,8 +61,8 @@ class DeviceTransport @Inject constructor(
             }
             btDevice?.type == BluetoothDevice.DEVICE_TYPE_LE -> { // LE only device
                 BlueLEDriver(
-                    context,
-                    protocolHandler
+                    context = context,
+                    protocolHandler = protocolHandler
                 ) {
                     flutterPreferences.shouldActivateWorkaround(it)
                 }

diff --git a/android/app/src/main/kotlin/io/rebble/cobble/bridges/common/ScanFlutterBridge.kt b/android/app/src/main/kotlin/io/rebble/cobble/bridges/common/ScanFlutterBridge.kt
@@ -3,6 +3,7 @@ package io.rebble.cobble.bridges.common
 import io.rebble.cobble.BuildConfig
 import io.rebble.cobble.bluetooth.scan.BleScanner
 import io.rebble.cobble.bluetooth.scan.ClassicScanner
+import io.rebble.cobble.bluetooth.toPigeon
 import io.rebble.cobble.bridges.FlutterBridge
 import io.rebble.cobble.bridges.ui.BridgeLifecycleController
 import io.rebble.cobble.pigeons.Pigeons

diff --git a/android/app/src/main/kotlin/io/rebble/cobble/datasources/FlutterPreferences.kt b/android/app/src/main/kotlin/io/rebble/cobble/datasources/FlutterPreferences.kt
@@ -91,7 +91,7 @@ private inline fun <T> SharedPreferences.flow(
 
         val listener = SharedPreferences
             .OnSharedPreferenceChangeListener { sharedPreferences: SharedPreferences,
-                                                changedKey: String ->
+                                                changedKey: String? ->
 
                 if (changedKey == key) {
                     trySend(mapper(sharedPreferences, key)).isSuccess

diff --git a/lib/ui/home/tabs/store_tab.dart b/lib/ui/home/tabs/store_tab.dart
@@ -9,14 +9,18 @@ class StoreTab extends StatefulWidget implements CobbleScreen {
 }
 
 class _StoreTabState extends State<StoreTab> {
+  late WebViewController controller;
+  @override
+  void initState() {
+    super.initState();
+    controller = WebViewController()
+      ..setJavaScriptMode(JavaScriptMode.unrestricted)
+      ..loadRequest(Uri.parse('https://store-beta.rebble.io/?native=true&platform=android'));
+  }
   @override
   Widget build(BuildContext context) {
     return CobbleScaffold.tab(
-      child: WebView(
-        initialUrl:
-            "https://store-beta.rebble.io/?native=true&platform=android",
-        javascriptMode: JavascriptMode.unrestricted,
-      ),
+      child: WebViewWidget(controller: controller),
     );
   }
 }