Fix bswap use on Android #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Bionic, __bswap_16 and __bswap_32 don't existe. They are named __swap16 and __swap32. These symbols are not meant for direct use as byteswap.h exposes bswap_16 and bswap_32 so let use them instead.
This avoids calls when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android uses Bionic libc which doesn't provide
__bswap_16nor__bswap_32(see byteswap.h).But byteswap.h provides public macros to use.
In addition, avoid using these calls when the compiler provides a builtin function (at least for GCC and Clang).