Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lower Expected Min Length #170

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

atsui-affinity
Copy link
Contributor

When running npm exec parse-domain-update, an error was encountered:

Fetching public suffix list from https://publicsuffix.org/list/public_suffix_list.dat...
parse-domain update failed: AssertionError [ERR_ASSERTION]: Public suffix list is shorter than expected

This PR lowers the FETCH_PSL_EXPECTED_MIN_LENGTH to resolve the issue

@jhnns
Copy link
Member

jhnns commented Aug 10, 2024

That's interesting. I've encountered these as well. After executing it a couple of times it might succeed though. It seems that the response from the public suffix list sometimes contains fewer entries. However, I haven't yet had time to get to the bottom of this (for example, to examine the response with a diff tool).

I'm not sure if this is the right fix. It's probably a good temporary fix if you can tolerate that there might some entries be missing.

@jhnns jhnns changed the title Lower Expected Min Length fix: Lower Expected Min Length Aug 10, 2024
@jhnns jhnns merged commit 0f62b8e into peerigon:main Aug 10, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 10, 2024
## [8.2.2](v8.2.1...v8.2.2) (2024-08-10)

### Bug Fixes

* Lower Expected Min Length ([#170](#170)) ([0f62b8e](0f62b8e))
Copy link

🎉 This issue has been resolved in version 8.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants