Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BTRFS #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add BTRFS #232

wants to merge 1 commit into from

Conversation

liberodark
Copy link

@liberodark liberodark commented Jan 18, 2024 •
edited
Loading

Fix : #158

michaelolbrich
michaelolbrich requested changes Jan 19, 2024
View reviewed changes
README.rst Outdated Show resolved Hide resolved
image-btrfs.c
get_opt("mkfsbtrfs"),
label ? "-L" : "",
label ? label : "",
label ? "-r" : "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. -r is the option for the rootfs and should not depend on the label, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im go look for this.

image-btrfs.c
}

static cfg_opt_t btrfs_opts[] = {
CFG_STR("label", NULL, CFGF_NONE),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an extraargs option like in all other filesystem images.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

test/filesystem.test Show resolved Hide resolved
@liberodark
Add BTRFS
2c985fe 
Signed-off-by: liberodark <liberodark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolbrich michaelolbrich michaelolbrich requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BTRFS Support
2 participants
@liberodark @michaelolbrich