image-hd: set the first usable lba correctly #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolbrich
force-pushed
the
first_usable_lba
branch
from
8b548a7 to
ee1a5bd
Compare
Villemoes
reviewed
Nov 8, 2024
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
michaelolbrich
force-pushed
the
first_usable_lba
branch
from
ee1a5bd to
e93fda0
Compare
Before this, the begining of the first partition was used. This leaves some unusable space between the partition table and the first partition and causes some Windows versions to alter the GPT. So set the first usable lba correctly: Set it to the first lba after the last non-partition data before the first partition. This will either be directly behind the GPT entry array or, for example after a bootloader that is placed between the partition table and the first partition. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
michaelolbrich
force-pushed
the
first_usable_lba
branch
from
e93fda0 to
1ccb8c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the begining of the first partition was used. This leaves
some unusable space between the partition table and the first partition
and causes some Windows versions to alter the GPT.
So set the first usable lba correctly: Set it to the first lba after the
last non-partition data before the first partition.
This will either be directly behind the GPT entry array or, for example
after a bootloader that is placed between the partition table and the
first partition.
Fixes: #262