Fix issue where data isn't overwritten with multiple calls to setup

peopleconnectus · Jul 28, 2021 · 27c9efb · 27c9efb
1 parent e72714e
commit 27c9efb
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/lib/brie.js b/lib/brie.js
@@ -38,7 +38,7 @@ const brie = module.exports = (function () {
     Object.assign(functionalCriteria, optCriteria);
     features = optFeatures;
     overrides = optOverrides;
-    Object.assign(data, optContext);
+    data = optContext
     rulesEngine.setup({
       criteria: functionalCriteria,
       features: features

diff --git a/test/helpers/setup.js b/test/helpers/setup.js
@@ -125,5 +125,41 @@ module.exports = function () {
       });
       assert(!!(bSetup));
     });
+
+    it("replaces data when called twice", function () {
+        const fakeNumber = '8675309'
+        const features = {
+          allowId:{
+            criteria: [{
+              allowValues: {
+                trait: "aId",
+                values: [
+                  fakeNumber
+                ]
+              }
+            }]
+          }
+        }
+
+        const b1 = brie.setup({
+          data: {
+            aId: fakeNumber
+          },
+          overrides: {},
+          features,
+        });
+
+        assert.deepEqual(b1.get('allowId'), true)
+
+        const b2 = b1.setup({
+          data: {
+            wrongId: "555555"
+          },
+          overrides: {},
+          features,
+        });
+
+        assert.deepEqual(b2.get('allowId'), false)
+    })
   });
 };