Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add more installation instructions #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add more installation instructions #1

wants to merge 1 commit into from

Conversation

4www
Copy link

@4www 4www commented May 29, 2018

Adding some steps that were required while implementing this addon.

Some interogations:

  • does these additions make sense?
  • is the example usage of a full file too specific?
  • should these required addons added as package.json dependencies?

@4www 4www requested review from amessinger and removed request for amessinger May 29, 2018 10:19
@4www 4www force-pushed the docs/installation-instructions branch 3 times, most recently from 6ff6af2 to 1abcaf8 Compare May 29, 2018 14:47
@GreatWizard GreatWizard force-pushed the docs/installation-instructions branch 2 times, most recently from 7413e07 to ef56e9a Compare December 2, 2019 09:23
@4www 4www requested a review from a team as a code owner December 2, 2019 15:44
xcambar
xcambar approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@xcambar xcambar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir!

@xcambar
Copy link
Contributor

xcambar commented Dec 20, 2019

Can you check/fix the CI, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcambar xcambar xcambar approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4www @xcambar