Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-332: don't pause cluster while running backup #545

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Oct 17, 2023

K8SPG-332 Powered by Pull Request Badge

https://jira.percona.com/browse/K8SPG-332

DESCRIPTION

Problem:
If we pause the cluster during a running backup, the backup will continue to run while the cluster is paused.

Cause:
We are not checking whether the cluster is paused when starting the backup or if the backup is running when attempting to pause it.

Solution:
We should check it and wait until the backup is finished if there is already a running backup, or until the cluster is unpaused if we're trying to pause the cluster.

This PR also fixes https://jira.percona.com/browse/K8SPG-279

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@pooknull pooknull marked this pull request as ready for review October 20, 2023 05:53
@pooknull pooknull requested a review from egegunes October 20, 2023 07:25
@JNKPercona
Copy link
Collaborator

Test name Status
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
users passed
We run 10 out of 10

commit: c8946c0
image: perconalab/percona-postgresql-operator:PR-545-c8946c083

@hors hors merged commit ff04153 into main Nov 2, 2023
11 checks passed
@hors hors deleted the dev/K8SPG-332 branch November 2, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants