K8SPSMDB-1170: set error state on failed reconcile of replset

[pooknull]

https://perconadev.atlassian.net/browse/K8SPSMDB-1170

CHANGE DESCRIPTION

Problem:
When spec.tls.allowInvalidCertificates is set to false, the operator is stuck on initializing replsets. There are errors in the log, but the cluster doesn't have .status.state set to error.

Solution:
Set error state, when reconcileCluster method fails.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported MongoDB version?
• Does the change support oldest and newest supported Kubernetes version?

[egegunes]

this doesn't fix the real problem. yes, now we're setting cluster state to error but operator still can't recover if you set tls.allowInvalidCertificates=false. Operator is now stuck in error state rather than initializing state.

[egegunes]

I'm OK to merge it since error state makes more sense but we shouldn't close K8SPSMDB-1156 after merging this. This PR doesn't fix K8SPSMDB-1156.

[pooknull]

@egegunes I agree that this PR doesn't fix K8SPSMDB-1156. But at least setting the cluster to error state will allow the cluster to be deleted if finalizers were specified

I will try to fix this issue in another PR

[JNKPercona]

Test name	Status
arbiter	passed
balancer	passed
custom-replset-name	passed
custom-tls	passed
custom-users-roles	passed
custom-users-roles-sharded	passed
cross-site-sharded	passed
data-at-rest-encryption	passed
data-sharded	passed
demand-backup	passed
demand-backup-eks-credentials	passed
demand-backup-physical	passed
demand-backup-physical-sharded	passed
demand-backup-sharded	passed
expose-sharded	passed
ignore-labels-annotations	passed
init-deploy	passed
finalizer	passed
ldap	passed
ldap-tls	passed
limits	passed
liveness	passed
mongod-major-upgrade	passed
mongod-major-upgrade-sharded	passed
monitoring-2-0	failure
multi-cluster-service	passed
non-voting	passed
one-pod	passed
operator-self-healing-chaos	passed
pitr	passed
pitr-sharded	passed
pitr-physical	passed
pvc-resize	passed
recover-no-primary	passed
replset-overrides	passed
rs-shard-migration	passed
scaling	passed
scheduled-backup	passed
security-context	passed
self-healing-chaos	passed
service-per-pod	passed
serviceless-external-nodes	passed
smart-update	passed
split-horizon	passed
storage	passed
tls-issue-cert-manager	passed
upgrade	passed
upgrade-consistency	passed
upgrade-consistency-sharded-tls	passed
upgrade-sharded	passed
users	passed
version-service	passed
We run 52 out of 52

commit: 37dd5b4
image: perconalab/percona-server-mongodb-operator:PR-1651-37dd5b4a