This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
PMM-10068: fix PMMServerSTTEnabled query #1131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritbl
commented
May 24, 2022
| @@ -32,14 +32,6 @@ telemetry: | |||
| - metric_name: "dbaas_enabled" | |||
| column: "dbaas_enabled" | |||
|
|
|||
| - id: PMMServerDBaaSEnabled | |||
There was a problem hiding this comment.
I see that we have a duplicate
ritbl
commented
May 24, 2022
| @@ -10,7 +10,7 @@ telemetry: | |||
|
|
|||
| - id: PMMServerSTTEnabled | |||
| source: PMMDB_SELECT | |||
| query: stt->'stt_enabled' AS stt_enabled FROM settings s, jsonb_extract_path(s.settings, 'sass') AS stt | |||
| query: (CASE WHEN stt->'stt_disabled' = 'false' THEN 'true' ELSE 'false' END) AS stt_enabled FROM settings s, jsonb_extract_path(s.settings, 'sass') AS stt | |||
There was a problem hiding this comment.
stt_enabled no longer exist
There was a problem hiding this comment.
can it be simplified like below?
Suggested change
| query: (CASE WHEN stt->'stt_disabled' = 'false' THEN 'true' ELSE 'false' END) AS stt_enabled FROM settings s, jsonb_extract_path(s.settings, 'sass') AS stt | |
| query: stt->'stt_disabled' != 'false' AS stt_enabled FROM settings s, jsonb_extract_path(s.settings, 'sass') AS stt |
idoqo
approved these changes
May 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 49.06% 49.22% +0.15%
==========================================
Files 182 148 -34
Lines 21448 19429 -2019
==========================================
- Hits 10524 9563 -961
+ Misses 9747 8726 -1021
+ Partials 1177 1140 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkadej
approved these changes
Jun 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-10068