PMM-9968 pmm-admin inventory add agent * --log-level #1134
Conversation
MySQL, MongoDB, Postgres, ProxySQL QANMySQLPerfSchema, QANMySQLSlowlog, QANMongoDBProfiler, QANPostgreSQLPgStatements, QANPostgreSQLPgStatMonitor RDS, AzureDatabase
YaroslavPodorvanov
requested review from
BupycHuk and
artemgavrilov
as code owners
YaroslavPodorvanov
changed the title
Command ./bin/pmm-admin inventory add agent azure-database-exporter not exists, but exists rds-exporter and also exists in pmm-managed AgentsService::AddAzureDatabaseExporter |
models/agent_helpers.go
Outdated
| @@ -22,6 +22,7 @@ import ( | |||
|
|
|||
| "github.com/AlekSi/pointer" | |||
| "github.com/google/uuid" | |||
| "github.com/percona/pmm/api/inventorypb" | |||
There was a problem hiding this comment.
Package "github.com/percona/pmm-managed/models" should not import package "github.com/percona/pmm/api/inventorypb" (blacklisted by "github.com/percona/pmm/api").
There was a problem hiding this comment.
So i SpecifyLogLevel use inside:
- "github.com/percona/pmm-managed/services/inventory"
- "github.com/percona/pmm-managed/services/management"
Both use "github.com/percona/pmm-managed/services"
So i will move "SpecifyLogLevel" to "github.com/percona/pmm-managed/services"
Codecov Report
@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
+ Coverage 48.69% 48.75% +0.05%
==========================================
Files 181 181
Lines 21257 21293 +36
==========================================
+ Hits 10351 10381 +30
- Misses 9768 9773 +5
- Partials 1138 1139 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
PMM-9968
Build: SUBMODULES-2536
PMM-9968 pmm-admin inventory add agent * --log-level pmm-admin#224