This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
PMM 9029: api tests: Connect to real DB for tests #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashankSinha252
requested review from
BupycHuk and
artemgavrilov
as code owners
ShashankSinha252
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
- Coverage 49.29% 49.06% -0.24%
==========================================
Files 180 182 +2
Lines 20826 21448 +622
==========================================
+ Hits 10267 10524 +257
- Misses 9426 9747 +321
- Partials 1133 1177 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BupycHuk
reviewed
Jun 13, 2022
| @@ -0,0 +1,295 @@ | |||
| // pmm-managed | |||
There was a problem hiding this comment.
can we include this test into api-tests directory?
There was a problem hiding this comment.
with that we will be able to remove a lot of duplications
| } | ||
|
|
||
| for _, pmmAgent := range agentListResponse.Payload.PMMAgent { | ||
| if pmmAgent.AgentID == "pmm-server" { |
There was a problem hiding this comment.
let's also check that this pmm-agent is connected.
|
API tests are failing with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9029
Build: SUBMODULES-2565