This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
PMM-7246 Tweak flags #605
Open
PMM-7246 Tweak flags #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,9 @@ func NewVictoriaMetricsParams(basePath string) (*VictoriaMetricsParams, error) { | |||
|
|
|||
| // UpdateParams - reads configuration file and updates corresponding flags. | |||
| func (vmp *VictoriaMetricsParams) UpdateParams() error { | |||
| // TODO read settings, set -external.url and -external.alert.source | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
models/victoriametrics.go:50: Line contains TODO/BUG/FIXME: "TODO read settings, set -external.url an..." (godox)
Codecov Report
@@ Coverage Diff @@
## PMM-2.0 #605 +/- ##
===========================================
+ Coverage 49.57% 49.65% +0.07%
===========================================
Files 123 123
Lines 15577 15562 -15
===========================================
+ Hits 7722 7727 +5
+ Misses 7143 7127 -16
+ Partials 712 708 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BupycHuk
approved these changes
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7246
Build: PMM-7246 Tweak flags Percona-Lab/pmm-submodules#1358
Links to other linked pull requests (optional).