Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

PMM-8877: turn ON IA by default, remove ability to disable it #834

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

oter
Copy link
Contributor

@oter oter commented Sep 29, 2021

PMM-8681

API PR: percona/pmm#786


  • Tests passed.
  • Feature build pass.
  • (Re)requested review.
  • Fix conflicts with target branch.
  • Update API dependency.
  • Update jira ticket description if needed.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #834 (95dee89) into main (35d1183) will increase coverage by 0.02%.
The diff coverage is 33.33%.

❗ Current head 95dee89 differs from pull request most recent head 9b3c1eb. Consider uploading reports for the commit 9b3c1eb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   50.30%   50.32%   +0.02%     
==========================================
  Files         174      174              
  Lines       20463    20428      -35     
==========================================
- Hits        10294    10281      -13     
+ Misses       9029     9010      -19     
+ Partials     1140     1137       -3     
Flag Coverage Δ
all 49.97% <33.33%> (+0.02%) ⬆️
cover 49.94% <33.33%> (+0.03%) ⬆️
crosscover 50.32% <33.33%> (+0.02%) ⬆️
update 12.62% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
models/settings.go 100.00% <ø> (ø)
models/settings_helpers.go 69.30% <ø> (-0.89%) ⬇️
services/management/ia/alerts_service.go 65.78% <0.00%> (+2.23%) ⬆️
services/management/ia/channels_service.go 9.25% <0.00%> (+0.16%) ⬆️
services/management/ia/rules_service.go 36.82% <0.00%> (+0.39%) ⬆️
services/management/ia/templates_service.go 46.38% <0.00%> (+0.49%) ⬆️
utils/envvars/parser.go 74.60% <ø> (+0.75%) ⬆️
services/server/server.go 34.17% <100.00%> (-0.40%) ⬇️
services/telemetry/telemetry.go 32.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d1183...9b3c1eb. Read the comment docs.

Copy link
Contributor

@artemgavrilov artemgavrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mark IA-related fields as deprecated in API definitions. Protobuf has a special tag for that

int32 old_field = 6 [deprecated = true];

services/management/ia/alerts_service.go Outdated Show resolved Hide resolved
services/management/ia/channels_service.go Show resolved Hide resolved
services/management/ia/rules_service.go Show resolved Hide resolved
@oter
Copy link
Contributor Author

oter commented Oct 12, 2021

Let's mark IA-related fields as deprecated in API definitions. Protobuf has a special tag for that

int32 old_field = 6 [deprecated = true];

@artemgavrilov PR for API created, FB updated.

Maksym Hilliaka and others added 4 commits November 9, 2021 12:43
…y-default

# Conflicts:
#	api-tests/server/settings_test.go
#	go.mod
#	go.sum
#	models/settings_helpers.go
#	models/settings_helpers_test.go
@oter oter assigned artemgavrilov and unassigned oter Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants