-
Notifications
You must be signed in to change notification settings - Fork 39
PMM-8877: turn ON IA by default, remove ability to disable it #834
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 50.30% 50.32% +0.02%
==========================================
Files 174 174
Lines 20463 20428 -35
==========================================
- Hits 10294 10281 -13
+ Misses 9029 9010 -19
+ Partials 1140 1137 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark IA-related fields as deprecated in API definitions. Protobuf has a special tag for that
int32 old_field = 6 [deprecated = true];
…urn-on-ia-by-default
…mm-managed into PMM-8877-turn-on-ia-by-default
@artemgavrilov PR for API created, FB updated. |
…urn-on-ia-by-default
…y-default # Conflicts: # api-tests/server/settings_test.go # go.mod # go.sum # models/settings_helpers.go # models/settings_helpers_test.go
PMM-8681
API PR: percona/pmm#786
Build: PMM-8877: FB turn ON IA by default, remove ability to disable it Percona-Lab/pmm-submodules#2043
Links to other linked pull requests (optional).